Skip to content

[No QA] [Payment due @truph01] Docs updates for E/A#96947 add Download receipts option to reports - #97740

Open
MelvinBot wants to merge 2 commits into
mainfrom
docs-downloadReceiptsFromReport
Open

[No QA] [Payment due @truph01] Docs updates for E/A#96947 add Download receipts option to reports#97740
MelvinBot wants to merge 2 commits into
mainfrom
docs-downloadReceiptsFromReport

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

#96947 adds a Download receipts option to the More menu on an expense report. It downloads all of the receipts attached to that report as a single zip file, with a status window that prepares the file and downloads it automatically (with a Download file fallback button).

This updates the help site to document the new option.

What changed

  • How-to-Export-Reports.md — Added a new section, How to download the receipts on a report, alongside the existing single-report Export (CSV) and Download as PDF flows, since Download receipts lives in the same report More menu.
  • Added two FAQ entries: why the option may not appear (it only shows when at least one expense on the report has a receipt), and what happens on partial failure.
  • Updated the article's description, keywords, and internalScope frontmatter to include receipts.

Notes / verification

  • Label and behavior verified against the merged PR code:
    • Menu label Download receipts (common.downloadReceipts).
    • The option is gated behind reportTransactions.some(hasReceipt) in ReportSecondaryActionUtils.ts, so it only appears when a report has at least one receipt.
    • exportReceiptsToZip calls the ExportReceiptsToZip command and produces a zip download; the status modal handles preparing → ready (auto-download) → partial/no-receipts/failed states.
  • I could not verify the option in the live UI because the automated test account had no expense reports with receipts to open. The wording above is drawn directly from the merged code, so please confirm it matches the current UI.

Fixed Issues

Related to #96947


@truph01, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: truph01 <truph01@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Aug 3, 2026
@truph01

truph01 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot Mark this PR as ready

@MelvinBot
MelvinBot marked this pull request as ready for review August 4, 2026 02:59
@MelvinBot

Copy link
Copy Markdown
Contributor Author

✅ Marked this PR as ready for review.

This is a docs-only change (a single HelpDot markdown file), so there's nothing to test in the app — no app-side verification was run.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment
This PR documents a new Download receipts option in the report More menu by extending the existing How-to-Export-Reports.md article. It adds one task-based section, two FAQ entries, and updates the frontmatter (description, keywords, internalScope) to reflect receipt downloads. The changes are consistent with the article existing structure and conventions.

Scores Summary

  • Readability: 9/10 - New section uses clear, sequential, action-oriented steps that mirror the existing export and PDF flows. Sentences are concise and scannable. The gating note is stated plainly.
  • AI Readiness: 9/10 - Section heading and FAQ questions are task/question-based, the full feature name Download receipts is used consistently, headings stay at H2 under a single top-level title, and internalScope/keywords were updated to match real search intent (download receipts, receipt zip).
  • Style Compliance: 9/10 - UI labels (Download receipts, More, Download file, Spend > Reports) are bolded and match the merged code. Navigation uses the approved unified web/mobile phrasing. FAQ questions follow the Why/What conventions and avoid generic headings.

Key Findings

  • Strong consistency: the new How to download the receipts on a report section deliberately parallels the adjacent single-report Export and Download as PDF flows, keeping the article cohesive.
  • The single-workflow-per-article principle is respected: receipt download is a natural sibling of the existing report-export workflows already scoped to this file.
  • FAQ entries are genuinely useful (visibility gating and partial-failure behavior) and match the code-verified behavior described in the PR.
  • The section heading is task-based and searchable; consider whether including the feature name (Download receipts) in the heading would further aid retrieval, though the current phrasing is acceptable.
  • Author flagged that wording was derived from merged code and not verified in the live UI. Per the Core UI Referencing Rules (exact label match), the reviewer should confirm Download receipts and the Download file fallback match the current UI.

Recommendations

  • Priority: Reviewer to confirm exact UI labels (Download receipts, Download file) against the live product, since these were sourced from code rather than the rendered UI.
  • Optional: Consider surfacing the feature name in the section heading for stronger AI retrieval.
  • No blocking style or structure issues found.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/How-to-Export-Reports.md: Added one task-based section, two FAQ entries, and updated frontmatter. Compliant with governance; only outstanding item is live-UI label verification.

Note: Detailed line-by-line feedback has been provided as inline comments.

@melvin-bot melvin-bot Bot changed the title Docs updates for E/A#96947 add Download receipts option to reports [Payment due @truph01] Docs updates for E/A#96947 add Download receipts option to reports Aug 4, 2026
@melvin-bot

melvin-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown

🎯 @truph01, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - no internal issue.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

@stephanieelliott
stephanieelliott requested a review from a team August 6, 2026 05:10
@melvin-bot

melvin-bot Bot commented Aug 6, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @strepanier03

@melvin-bot
melvin-bot Bot requested a review from strepanier03 August 6, 2026 05:10
@melvin-bot

melvin-bot Bot commented Aug 6, 2026

Copy link
Copy Markdown

@strepanier03 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team August 6, 2026 05:10
@github-actions github-actions Bot changed the title [Payment due @truph01] Docs updates for E/A#96947 add Download receipts option to reports [No QA] [Payment due @truph01] Docs updates for E/A#96947 add Download receipts option to reports Aug 6, 2026
@OSBotify

OSBotify commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://f0eda561.helpdot.pages.dev ⚡️

Updated articles:

@MelvinBot

Copy link
Copy Markdown
Contributor Author

The only failing check is Check independent approval (step "Verify peer review") — every other check is passing.

This isn't a code failure, so there's nothing to fix or push. This check gates on the PR having an independent human approval, and it stays red until a reviewer (someone other than the author) approves the PR. It's the same reason approveAndMerge is skipped.

To resolve: get an independent reviewer to approve this PR — no code change is needed.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Still the same as my previous reply — nothing has changed and there's no code fix to push.

The only red check is Check independent approval (step "Verify peer review"). Every other check passes. This is a governance gate, not a code/test failure: it stays red until an independent human reviewer (someone other than the author) approves the PR, which is also why approveAndMerge is skipped.

To resolve: get an independent reviewer to approve this PR. No commit or code change from me will clear it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants